Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need an easy way to sign a message #633

Open
bota87 opened this issue Aug 12, 2023 · 9 comments
Open

Need an easy way to sign a message #633

bota87 opened this issue Aug 12, 2023 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@bota87
Copy link

bota87 commented Aug 12, 2023

Is your feature request related to a problem? Please describe.

Some services require you to sign a message with the address you want to use to receive

Describe the solution you'd like

A tool that ask for the address, the message to sign and return the signature, like sparrow/electrum wallets

@bota87 bota87 added the enhancement New feature or request label Aug 12, 2023
@theborakompanioni
Copy link
Collaborator

theborakompanioni commented Aug 12, 2023

Hey @bota87! Thanks for the feature request.
It would be nice to have this ability in Jam, however, such functionality is currently not exposed via the JM API.
Would it be sufficient to use the CLI? I think wallet-tool.py exposes a command signmessage which should be exactly what you are looking for.

@bota87
Copy link
Author

bota87 commented Aug 12, 2023

Yeah I've solved with wallet-tool but it's a little bit tricky, especially having to set the hd wallet path instead of the address.
docker exec -it jam wallet-tool.py -H "m/84'/0'/2'/0/2" /root/.joinmarket/wallets/jam_wallet.jmdat signmessage "the message to sign"

@theborakompanioni
Copy link
Collaborator

Yeah I've solved with wallet-tool but it's a little bit tricky

👍

If this feature will find its way into the JM API, Jam will happily adopt it!

@bota87
Copy link
Author

bota87 commented Aug 12, 2023

Ok I've opened an issue on JM repo, let's see how it goes 🤞

@theborakompanioni theborakompanioni added the blocked Merging this pull request is blocked until another issue is resolved label Sep 19, 2023
@editwentyone editwentyone added this to JAM Oct 13, 2023
@theborakompanioni
Copy link
Collaborator

Ready for development. See JoinMarket-Org/joinmarket-clientserver#1536 (not merged yet).

@theborakompanioni theborakompanioni added help wanted Extra attention is needed good first issue Good for newcomers and removed blocked Merging this pull request is blocked until another issue is resolved labels Jan 8, 2024
@kristapsk
Copy link
Contributor

Ready for development. See JoinMarket-Org/joinmarket-clientserver#1536 (not merged yet).

Waiting for feedback from you or somebody else that it works well with Jam, then will merge.

@theborakompanioni
Copy link
Collaborator

ping @editwentyone

@editwentyone
Copy link

first draft, more clarification tomorrow in sync call
https://www.figma.com/file/kfejZJFlwBywvLEnPEmJo1/JoinMarket-UI?type=design&node-id=3283-85955&mode=design&t=6FQUVMTrmfxSlFjm-11

@editwentyone
Copy link

new update after call:
https://www.figma.com/file/kfejZJFlwBywvLEnPEmJo1/JoinMarket-UI?type=design&node-id=6600-17405&mode=design&t=5062kYXLtdJFrL4Y-11

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: No status
Development

No branches or pull requests

4 participants