Declare support for Python 3.13 #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
force-pushed
the
py313
branch
3 times, most recently
from
85dca33 to
49c23b9
Compare
|
Tests are 🟢 over on my fork: https://github.com/edgarrmondragon/faker/actions/runs/9849708765 |
.github/workflows/ci.yml
Outdated
| @@ -154,6 +160,7 @@ jobs: | |||
| uses: actions/setup-python@v5 | |||
| with: | |||
| python-version: ${{ matrix.python }} | |||
| allow-prereleases: true | |||
There was a problem hiding this comment.
Why not using "3.13-dev" instead to better indicate that Python 3.13 is not yet available as a stable release?
There was a problem hiding this comment.
Feels easier to let it stay as 3.13 after the final release rather than coming back and changing it from 3.13-dev to 3.13. I don't have a strong preference, though.
|
Rebased and confirmed with |
edgarrmondragon
force-pushed
the
py313
branch
from
cb9e384 to
c2a3da3
Compare
edgarrmondragon
commented
Oct 15, 2024
edgarrmondragon
commented
Oct 15, 2024
edgarrmondragon
commented
Oct 15, 2024
|
ping @fcurella 🙏 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
The first release candidate of Python 3.13 is around the corner (2024-07-30), this adds it to the test matrix and declares support in the project metadata.
What was wrong
Python 3.13 seems to be supported without any code changes, but this makes sure it's tested.
How this fixes it
3.13to the list of versions foractions/setup-python