Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes today in thread gem prevent sneakers work method from being called #112

Closed
subvertallchris opened this issue Apr 7, 2015 · 9 comments · Fixed by #115
Closed

Comments

@subvertallchris
Copy link
Contributor

Spent the past few hours troubleshooting processing failures within an app using Sneakers on two different systems. No error messages, the work methods in my worker were just never getting called. I had a lot of changes to the app so I worked off the assumption that I had broken it. When I exhausted all the changes, I started looking at dependencies.

ruby-thread (thread gem) was updated four hours ago. Locking my Gemfile to thread's 0.1.5 version fixed it immediately. Not sure if my config has anything to do with it, let me know if I can help troubleshoot at all.

(Updating the subject, "break sneakers" is such a crappy description.)

@subvertallchris subvertallchris changed the title Changes today in thread gem break sneakers Changes today in thread gem prevent sneakers work method from being called Apr 7, 2015
@inventionlabsSydney
Copy link

We're also experiencing this issue, in worker.rb on line 47

    def do_work(delivery_info, metadata, msg, handler)
      worker_trace "Working off: #{msg}"

      @pool.process do # Worker is halted here

Pool.process is just halted and never gets past here, for the moment I'll try forcing a particular version of the thread gem.

@inventionlabsSydney
Copy link

Further to this locking my gem file to 0.1.5 of thread fixed this as well.
I'll check on thread's issue tracker and see if anyone else is experiencing on other projects.

@rud
Copy link
Contributor

rud commented Apr 8, 2015

Changes in thread gem in 0.1.6 since 0.1.5: meh/ruby-thread@827c7a1...915cac3

(Updated: now comparing two absolute versions instead of having master as one of the versions)

@inventionlabsSydney
Copy link

Thanks for that @rud
It seems that the problem exists with using the @done_mutex.synchronize.

I wonder what might be going on here, I am entirely unsure.

@rud
Copy link
Contributor

rud commented Apr 8, 2015

I think this is the issue, was just reported: meh/ruby-thread#34

@jondot
Copy link
Owner

jondot commented Apr 8, 2015

Wow awesome findings guys. I've just merged and cutting a new version!
Thanks!

@jondot
Copy link
Owner

jondot commented Apr 8, 2015

1.0.3 now in Rubygems

@subvertallchris
Copy link
Contributor Author

Killer, thanks for the jumping on this.

@inventionlabsSydney
Copy link

Thanks @jondot!

Muchos appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants