Skip to content

Latest commit

 

History

History
107 lines (68 loc) · 3.5 KB

CONTRIBUTING.md

File metadata and controls

107 lines (68 loc) · 3.5 KB
Raw

Thanks for contributing, you rock!

Think You Found a Bug?

Please conform to the issue template and provide a clear path to reproduction with a code example. Best is a pull request with a failing test. Next is a link to CodePen/JS Bin or repository that illustrates the bug. Finally, some copy/pastable code is acceptable.

Proposing New or Changed API?

Please provide thoughtful comments and some sample code. Proposals without substance will be closed.

It's generally a good idea to open an issue for the proposal first before working on the implementation and submitting a pull request. Please also take a look at the timeline issue and consider ongoing work that might conflict with your proposed changes.

Issue Not Getting Attention?

If you need a bug fixed and nobody is fixing it, it is greatly appreciated if you provide a fix for it. Issues with no activity for 60 days will be automatically closed, with a warning 7 days before closing.

Making a Pull Request?

Pull requests need only the 👍 of two or more collaborators to be merged; when the PR author is a collaborator, that counts as one.

Tests

All commits that fix bugs or add features need a test.

<blink>Do not merge code without tests.</blink>

Docs + Examples

All commits that change or add to the API must be done in a pull request that also updates all relevant examples and docs.

Setup

The following steps will get you setup to contribute changes to this repo:

  1. Fork the repo (click the Fork button at the top right of this page).
  2. Clone your fork locally.
# in a terminal, cd to parent directory where you want your clone to be, then
git clone https://github.com/<your_github_username>/react-router.git
cd react-router
  1. Install dependencies and build. React Router uses npm, so you should too. If you install using yarn, unnecessary yarn lock files will be generated.
npm install
npm run build

Development

Packages

React Router uses a monorepo to host code for multiple packages. These packages live in the packages directory.

React Router uses Lerna to manage the monorepo. Lerna sets up symlinks between the packages, so when you build one package, its changes will be automatically available to the packages that depend on it.

Building

Calling npm run build from the root directory will build every package. If you want to build a specific package, you should cd into that directory.

# build everything
npm run build
# build react-router-dom
cd packages/react-router-dom
npm run build

Testing

Calling npm test from the root directory will run every package's tests. If you want to run tests for a specific package, you should cd into that directory.

# all tests
npm test
# react-router-dom tests
cd packages/react-router-dom
npm test

React Router uses Jest to run its tests, so you can provide the --watch flag to automatically re-run tests when files change.

Website

The code for the documentation website lives in the website directory. cd into there and call npm start to start a development server on http://localhost:8080 that will watch for changes.

cd website
npm start