-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port difffolded.pl #62
Comments
I just realized that the output of We could deal with this in one of the following ways:
Thoughts? |
Hmm, that's a good point... I'm tempted to do (1), but that would mean that we're not compatible with files generated by upstream's Amidst all these, I think (2) is sadly the right way to go. It will likely give us quite a performance hit since we can no longer do streaming work. Quantifying that would be good (shouldn't be too hard now with #88). At least we can use |
Yeah, it's sad to have to always sort even when we know most of the time the input is already sorted, but I do agree that it would be best to remain as compatible as possible with upstream. I'll do some benchmarks to see what the performance difference is. |
I think it's not even so much the sorting itself, but the |
Yeah, I get that. Here are the benchmarks. No sorting:
Sorting:
|
Okay, so not quite as bad as I'd thought then. |
I'll add a PR for the flamegraph benchmark since #88 only added benchmarks for collapse. |
That seems like an excellent plan! What input are you using? |
tests/data/collapse-perf/results/example-perf-stacks-collapsed.txt |
Now that #60 has landed, it would be nice if inferno could generate the differential profile files that this feature expects. Currently you need to use difffolded.pl from upstream FlameGraph. We should port this to Rust.
See Differential Flame Graphs for more info.
The text was updated successfully, but these errors were encountered: