Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexing a ComponentArray with an KeepIndex(array of symbols) #129

Closed
bgctw opened this issue May 26, 2022 · 1 comment
Closed

Indexing a ComponentArray with an KeepIndex(array of symbols) #129

bgctw opened this issue May 26, 2022 · 1 comment

Comments

@bgctw
Copy link

bgctw commented May 26, 2022

Similar to #71.
However, if the result is still a ComponentArray, then the behaviour should be well defined and work with matrices and other types too.

This would also allow #71 to work with
getdata(cv[KeepIndex([:a,:b])])

@bgctw
Copy link
Author

bgctw commented Jun 2, 2022

Thanks, @jonniedie.
How about the edge cases?

   @test ca[(:a,)] == ca[KeepIndex(:a)] # using setup near runtest.jl line 173
   @test ca[[:a]] == ca[KeepIndex(:a)]
   ca[()] #? what is an empty ComponentVector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant