Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Documentation for Two.js #295

Closed
jonobr1 opened this issue Jul 2, 2018 · 15 comments
Closed

Update Documentation for Two.js #295

jonobr1 opened this issue Jul 2, 2018 · 15 comments
Assignees
Milestone

Comments

@jonobr1
Copy link
Owner

jonobr1 commented Jul 2, 2018

This is a multipart issue:

  1. Update documentation based on jsdocs formatting
  2. Render documentation with jsdoc-to-markdown
  3. Style documentation based on https://two.js.org/ and include with dev repository for local development
@jonobr1 jonobr1 added this to the v0.7.0 milestone Jul 2, 2018
@jonobr1 jonobr1 self-assigned this Jul 2, 2018
@jonobr1 jonobr1 changed the title Add Explainer to Documentation on how to extend Two.js Classes Update Documentation for Two.js Mar 28, 2019
@jonobr1
Copy link
Owner Author

jonobr1 commented Mar 28, 2019

Have currently added documentation to all "top level" src files. Now need to go through src/effects, src/renderer, and src/shapes and add documentation there to complete step one.

Screen Shot 2019-03-28 at 8 36 37 AM

@eulertour
Copy link
Contributor

Have currently added documentation to all "top level" src files. Now need to go through src/effects, src/renderer, and src/shapes and add documentation there to complete step one.

Is this true? Looking at the documentation at https://two.js.org/#documentation, it seems that documentation for Two.Matrix, Two.Registry and Two.Shape are missing.

@jonobr1
Copy link
Owner Author

jonobr1 commented Aug 11, 2019

@eulertour, the most up-to-date documentation lives in the source files now. This documentation has yet to be generated because I'm still writing it for each class, property, function, etc. Inline above each property there is a jsdoc style comment that describes what it does or expects.

I still have the effects folder and the renderers folder to do before I tackle rendering the documentation into HTML.

@jonobr1 jonobr1 modified the milestones: v0.7.0, v0.8.0 Jan 22, 2020
@meetzaveri
Copy link

Hey Jono,

Just wanted to let you know that some of the new APIs(such as two.makeArrow) are not part of the documentation.

Is documentation moved away or it isn't updated acc. to latest stable release of 0.7.0?

@jonobr1
Copy link
Owner Author

jonobr1 commented May 31, 2020

Thanks for your post @meetzaveri, if you read the thread you'll see that the documentation has been moved to the source code as jsdocs style comments. This issue is to track generating and styling the new documentation for the site.

If you'd like to see what exists so far you can pull the latest dev repository, npm install, run npm run docs:generate, and finally npm run docs:dev.

@meetzaveri
Copy link

meetzaveri commented May 31, 2020

Got it. This clears out my confusion.

@jonobr1
Copy link
Owner Author

jonobr1 commented Mar 23, 2021

New designs for the Two.js site and documentation by the amazing @yuinchien:

Overview Page
Here's the figma file.

@meetzaveri
Copy link

New design looks dope

@meetzaveri
Copy link

I think with this new design, API docs looks more accurate than before.

Any idea when will be new design pushed?

@jonobr1
Copy link
Owner Author

jonobr1 commented Mar 24, 2021

No clear timeline on when this will all be implemented. But, slowly making progress!

Thanks for your patience.

@jonobr1
Copy link
Owner Author

jonobr1 commented Nov 28, 2021

Updated documentation is up on http://two.js.org/ now. Enjoy!

@jonobr1 jonobr1 closed this as completed Nov 28, 2021
@yuinchien
Copy link

Screen Shot 2021-11-28 at 12 31 54 PM

For mobile, perhaps you can remove the floating button label, having the button in circle shape is better for small screen.

@yuinchien
Copy link

Screen Shot 2021-11-28 at 12 35 33 PM

Text in looks very thin, might want to increase font-weight.

@yuinchien
Copy link

Screen Shot 2021-11-28 at 12 37 07 PM

The vertical line should left align with the category label, ~5px to the right.

@jonobr1
Copy link
Owner Author

jonobr1 commented Nov 28, 2021

Thanks @yuinchien, made those updates and just pushed them to the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants