Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not work inside Atom (packages) #19

Open
JaninaWibker opened this issue Oct 3, 2017 · 4 comments
Open

does not work inside Atom (packages) #19

JaninaWibker opened this issue Oct 3, 2017 · 4 comments

Comments

@JaninaWibker
Copy link

When using inside Atom (or probably any electron app) the returned path is incorrect if the fallback is used since process.execPath is not the node executable but instead the electron app:

$ process.execPath
/Applications/Atom.app/Contents/Frameworks/Atom Helper.app/Contents/MacOS/Atom Helper
@jonschlinkert
Copy link
Owner

want to do a pr?

@JaninaWibker
Copy link
Author

Wouldn't know how to fix this. Just trying to avoid falling back to the fallback function (as a user of this package) could work (I just set the PREFIX ENV variable).

@jonschlinkert
Copy link
Owner

Ok, no prob. I'll look into it more, I believe I saw a solution to this at some point. If someone else notices this issue and has ideas, I would greatly appreciate if you shared them or did a pr. thanks

@kachkaev
Copy link

kachkaev commented Oct 3, 2019

I confirm that the problem still exists. It is presenting itself in prettier-atom: prettier/prettier-atom#448

When global modules are installed via NVM, global-modules (which relies on global-prefix) returns null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants