Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: sincedb doesn't handle multiple files #18

Closed
bwmeier opened this issue May 30, 2013 · 4 comments
Closed

Windows: sincedb doesn't handle multiple files #18

bwmeier opened this issue May 30, 2013 · 4 comments

Comments

@bwmeier
Copy link
Contributor

bwmeier commented May 30, 2013

The logic for sincedb in filewatch depends on the inode number in stat being a reasonable unique identifier for the file being watched. Unfortunately, the inode number returned by stat in windows is always 0, so multiple files are collapsed into one file, and bizarre behavior results. Perhaps a better identifier is the path in some form?

@trajano
Copy link

trajano commented Sep 23, 2013

Is this still occurring? Does it affect logstash/logstash?

@bwmeier
Copy link
Contributor Author

bwmeier commented Sep 23, 2013

I branched and fixed locally. No idea if it was fixed in the main code base.

@stoerr
Copy link

stoerr commented Mar 7, 2014

Yes - it does affect logstash. See https://logstash.jira.com/browse/LOGSTASH-1216 , which reproduces the bug there. So it would be a good idea to use, say, the absolute path instead of the inode as a backup when the inode is 0. Or just include wemeiers fix.

@guyboertje
Copy link
Contributor

This has long been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants