Alias and name checks on aggregates do not raise exception #485

filcole · 2020-03-06T10:50:13Z

The checking in XrmFakedContext.Aggregations.cs against IsNullOrEmpty is for a literal string, rather than the variable, which causes exception to never fire, e.g.

                if (string.IsNullOrEmpty("alias"))
                {
                    throw new Exception("Missing alias for attribute in aggregate fetch xml");
                }
                if (string.IsNullOrEmpty("name"))
                {
                    throw new Exception("Missing name for attribute in aggregate fetch xml");
                }

filcole changed the title ~~Alias and name checks on aggregates do not fire~~ Alias and name checks on aggregates do not raise exception Mar 6, 2020

filcole linked a pull request Mar 6, 2020 that will close this issue

Alias and name checks #486

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alias and name checks on aggregates do not raise exception #485

Alias and name checks on aggregates do not raise exception #485

filcole commented Mar 6, 2020

Alias and name checks on aggregates do not raise exception #485

Alias and name checks on aggregates do not raise exception #485

Comments

filcole commented Mar 6, 2020