From a99e90128c1c6f4c3984860f4d695f9e858423cf Mon Sep 17 00:00:00 2001 From: David Iglesias Date: Thu, 16 Apr 2020 17:33:47 -0700 Subject: [PATCH] [video_player_web] Add a custom analysis_options file to video_player_web. (#2658) flutter/plugins is currently red because inline analysis checks are no longer honored. `video_player_web` used a web-only API that was being flagged (correctly) by the analyzer, but suppressed inline via `// ignore` comments. Now that `// ignore` comments don't work, the tree has gone red. A proper fix for `video_player_web` will take longer than acceptable to unblock the flutter/plugins tree. This is a temporary mitigation so work can resume. --- packages/video_player/video_player_web/CHANGELOG.md | 4 ++++ .../video_player_web/analysis_options.yaml | 10 ++++++++++ packages/video_player/video_player_web/pubspec.yaml | 2 +- script/incremental_build.sh | 1 + 4 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 packages/video_player/video_player_web/analysis_options.yaml diff --git a/packages/video_player/video_player_web/CHANGELOG.md b/packages/video_player/video_player_web/CHANGELOG.md index 00fc486131bf..f5408fa636ce 100644 --- a/packages/video_player/video_player_web/CHANGELOG.md +++ b/packages/video_player/video_player_web/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.1.2+2 + +* Add `analysis_options.yaml` to the package, so we can ignore `undefined_prefixed_name` errors. Works around https://github.com/flutter/flutter/issues/41563. + ## 0.1.2+1 * Make the pedantic dev_dependency explicit. diff --git a/packages/video_player/video_player_web/analysis_options.yaml b/packages/video_player/video_player_web/analysis_options.yaml new file mode 100644 index 000000000000..443b16551ec9 --- /dev/null +++ b/packages/video_player/video_player_web/analysis_options.yaml @@ -0,0 +1,10 @@ +# This is a temporary file to allow us to unblock the flutter/plugins repo CI. +# It disables some of lints that were disabled inline. Disabling lints inline +# is no longer possible, so this file is required. +# TODO(ditman) https://github.com/flutter/flutter/issues/55000 (clean this up) + +include: ../../../analysis_options.yaml + +analyzer: + errors: + undefined_prefixed_name: ignore diff --git a/packages/video_player/video_player_web/pubspec.yaml b/packages/video_player/video_player_web/pubspec.yaml index e1435c893b8a..7cf036ef5b4b 100644 --- a/packages/video_player/video_player_web/pubspec.yaml +++ b/packages/video_player/video_player_web/pubspec.yaml @@ -1,7 +1,7 @@ name: video_player_web description: Web platform implementation of video_player homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player_web -version: 0.1.2+1 +version: 0.1.2+2 flutter: plugin: diff --git a/script/incremental_build.sh b/script/incremental_build.sh index 9534d62ac341..3b0b97f0dbe6 100755 --- a/script/incremental_build.sh +++ b/script/incremental_build.sh @@ -16,6 +16,7 @@ source "$SCRIPT_DIR/common.sh" CUSTOM_ANALYSIS_PLUGINS=( "in_app_purchase" "camera" + "video_player/video_player_web" ) # Comma-separated string of the list above readonly CUSTOM_FLAG=$(IFS=, ; echo "${CUSTOM_ANALYSIS_PLUGINS[*]}")