Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer-to-peer-review #2

Open
4 tasks
qwibbler opened this issue Nov 19, 2021 · 0 comments
Open
4 tasks

Peer-to-peer-review #2

qwibbler opened this issue Nov 19, 2021 · 0 comments

Comments

@qwibbler
Copy link

qwibbler commented Nov 19, 2021

♻️ Great job so far implementing the desktop version of your portfolio website. Your design and code look clean and match the template very well! ⭐ 🚀 🪐 According to our morning session, the team suggests the following changes:

  • Your use of mask to change the logo background was very cool.
  • You can implement the more/less button in the mobile version for the speakers.
  • The footer has the cc common logo, not your vueConf logo. I think it is meant to be your own logo.
  • In mobile version, you might want to have less information in both the about the logo section and the footer.

Good Luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant