From dbcce63b925118bb1ba35455a684a21620a250ac Mon Sep 17 00:00:00 2001
From: Vibhatha Lakmal Abeykoon <vibhatha@users.noreply.github.com>
Date: Thu, 6 Jun 2024 10:42:47 +0530
Subject: [PATCH] MINOR: [Java] Bump com.google.errorprone:error_prone_core
 from 2.10.0 to 2.28.0 in /java - Manual Fix (#41996)

### Rationale for this change

Based on the [dependabot PR ](https://github.com/apache/arrow/pull/41944), making correct amendments to reflect the necessary error-prone library upgrade.

### What changes are included in this PR?

- [X] Upgrade error-prone version for JDK 11+
- [X] Keeping the existing error-prone version for JDK 8, and added notes and references as reasoning.

### Are these changes tested?

Tested by existing build.

### Are there any user-facing changes?

No

Authored-by: Vibhatha Abeykoon <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
---
 java/pom.xml | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/java/pom.xml b/java/pom.xml
index a59d29c576398..0e9b7f0e25a34 100644
--- a/java/pom.xml
+++ b/java/pom.xml
@@ -94,9 +94,7 @@
     <forkCount>2</forkCount>
     <checkstyle.failOnViolation>true</checkstyle.failOnViolation>
     <errorprone.javac.version>9+181-r4173-1</errorprone.javac.version>
-    <error_prone_core.version>2.24.0</error_prone_core.version>
-    <error_prone_annotations.version.jdk11>2.24.0</error_prone_annotations.version.jdk11>
-    <error_prone_annotations.version.jdk8>2.10.0</error_prone_annotations.version.jdk8>
+    <error_prone_core.version>2.28.0</error_prone_core.version>
     <maven-compiler-plugin.version>3.12.1</maven-compiler-plugin.version>
     <mockito.core.version>5.11.0</mockito.core.version>
     <mockito.inline.version>5.2.0</mockito.inline.version>
@@ -946,6 +944,9 @@
            Do not activate Error Prone while running with Eclipse/M2E as it causes incompatibilities
            with other annotation processors.
            See https://github.com/jbosstools/m2e-apt/issues/62 for details
+
+           Note: Maintaining error-prone version with JDK8
+           See https://github.com/google/error-prone/blob/f8e33bc460be82ab22256a7ef8b979d7a2cacaba/docs/installation.md#jdk-8
       -->
       <activation>
         <jdk>1.8</jdk>
@@ -969,6 +970,13 @@
                 <path>
                   <groupId>com.google.errorprone</groupId>
                   <artifactId>error_prone_core</artifactId>
+                  <!--
+                       Reference: https://errorprone.info/docs/installation
+                       Error Prone 2.10.0 is the latest version
+                       to support running on JDK 8.
+                       With right flags it could be upgraded,
+                       but we choose to keep this unchanged for now. 
+                  -->
                   <version>2.10.0</version>
                 </path>
               </annotationProcessorPaths>