Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options for displaying large job output? #3

Closed
benodom opened this issue Feb 16, 2015 · 5 comments
Closed

options for displaying large job output? #3

benodom opened this issue Feb 16, 2015 · 5 comments

Comments

@benodom
Copy link

benodom commented Feb 16, 2015

Hello,

Thanks for the gem. I am making use of this, but I find that Slack's limitation on message size is a problem for us. Most of our jobs can't be displayed in one message, and I will be looking for ways to display these, either with links to static files served via nginx, or ideally with the ability to create a snippet/attachment in slack with the jobs output file. Let me know if you have feedback, thanks!

@josacar
Copy link
Owner

josacar commented Feb 21, 2015

We are suffering this issue too, Slack's RTM api limits each message to 10KB which can be too small sometimes. The issue there is maybe of lita or the adapter itself, for slack maybe offering an API to paste text as it happened in Campfire adapter for example ( just introspect if it's a multiline message or not ).

I miss this feature too, maybe @jimmycuadra can give us some light :)

@jimmycuadra
Copy link

I haven't looked into it yet, but I do know that's support for attachments is being worked on for the Hubot adapter. Take a look at slackapi/hubot-slack#108 and slackapi/hubot-slack#148.

@benodom
Copy link
Author

benodom commented Feb 27, 2015

@josacar @jimmycuadra thanks for the input. I am going to fork lita-slack and add a conditional here: https://github.com/kenjij/lita-slack/blob/master/lib/lita/adapters/slack/rtm_connection.rb#L103 that will auto-convert the large message into an attachment instead of dropping it on the floor and raising an exception. Thoughts?

@jimmycuadra
Copy link

I'm not sure if it will fit your use case, but lita-slack should probably not simply raise an exception when a message is larger than Slack's limit – it should sent it in chunks. I believe this is what the Hubot adapter does if you want to look at that for an example.

I also think it'd be useful to somehow expose Slack's attachment API to Lita, but I don't want to clutter this issue with discussing the details of that. An issue on lita-slack would be more appropriate.

@benodom
Copy link
Author

benodom commented Feb 27, 2015

thanks @jimmycuadra I'll open up an issue on lita-slack to continue this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants