Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to the latest version #401

Closed
josdem opened this issue Nov 7, 2024 · 6 comments · Fixed by #412
Closed

Update dependencies to the latest version #401

josdem opened this issue Nov 7, 2024 · 6 comments · Fixed by #412

Comments

@josdem
Copy link
Owner

josdem commented Nov 7, 2024

As developer, I would like to see latest versions in the project so that I can be up to date

Acceptance Criteria

  • Spring Boot is updated to 3.3.5
  • Flyway MySQL is updated to 10.21.0
  • Spring cloud gcp dependencies to 5.8.0
  • Replace org.mockito:mockito-inline by 'org.mockito:mockito-core' version 5.14.2`
  • Delete dependency org.codehaus.groovy.modules.http-builder since it is not required anymore
  • All test are passing
@tkim602
Copy link
Collaborator

tkim602 commented Nov 8, 2024

Hi I want to work on this issue. Could you assign it to me?

@josdem
Copy link
Owner Author

josdem commented Nov 8, 2024

Hi I want to work on this issue. Could you assign it to me?

Hi @tkim602 , absolutely, your collaboration is appreciated, let me know if any questions.

@tkim602
Copy link
Collaborator

tkim602 commented Nov 8, 2024

Hi I made following updates to the build.gradle file as per your recommendation. Despite the changes, I am still encountering Hibernate dialect errors during the test (./gradlew test). I noticed that 35 out of 129 tests failed. While I do not have a complete stack tracing at the moment, the errors seem to be related to incorrect Hibernate configuration. I have tried updating build.gradle, cleared cache, and rebuilt the project. Since I am a beginner at contributions, it might be just on me lacking of skills. Could you please provide me guidance on how to resolve this? Thank you.

@josdem
Copy link
Owner Author

josdem commented Nov 8, 2024

Hi @tkim602 I sent you a collaboration request to make the things easier, once you accept you have a couple of options:

  1. Create the necessary setup in your local computer, you can find the instructions in the wiki page take a look at the configuration and run sections.
  2. Create a PR from this repository and GitHub actions will run the tests for you.
    Thank you for your collaboration, let me know if any more questions.

@tkim602
Copy link
Collaborator

tkim602 commented Nov 8, 2024

thank you for the support. I've just created a new PR.

@josdem
Copy link
Owner Author

josdem commented Nov 9, 2024

PR merged: #412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment