Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VIA support for Sofle Choc #194

Closed
JellyTitan opened this issue Jan 11, 2024 · 7 comments
Closed

Add VIA support for Sofle Choc #194

JellyTitan opened this issue Jan 11, 2024 · 7 comments
Labels
enhancement New feature or request Sofle-Choc

Comments

@JellyTitan
Copy link
Contributor

I'd like to add VIA support for the Sofle Choc.
Since there's already a via folder on the QMK side, the config on the VIA side needs to be added.
I didn't see any open PR's, so I went ahead and submitted one for the Sofle Choc: the-via/keyboards#2139
All PR's are paused on VIA for December/January, so it'll sit for a bit.

@JellyTitan JellyTitan added the enhancement New feature or request label Jan 11, 2024
@JellyTitan
Copy link
Contributor Author

JellyTitan commented Feb 14, 2024

The VIA PR is blocked because in the QMK branch the Product ID and the VendorID are the same as the Sofle rev1.
image

@brianlow do you mind if i put in a PR with QMK to make it unique?

@brianlow
Copy link
Contributor

@JellyTitan go for it!

@JellyTitan
Copy link
Contributor Author

The PR for the vid/pid choc was closed and moved to a new PR. (Same code).
qmk/qmk_firmware#24030

@JellyTitan
Copy link
Contributor Author

@brianlow The PR to make the Sofle Choc VID/PID unique has been approved and merged into QMK master. The VIA PR has been updated.

@brianlow
Copy link
Contributor

brianlow commented Jul 5, 2024

Great, let me know if you need anything

@JellyTitan
Copy link
Contributor Author

VIA support has been approved and merged. @brianlow is documentation support warranted?

@brianlow
Copy link
Contributor

brianlow commented Jul 8, 2024

Up to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Sofle-Choc
Projects
None yet
Development

No branches or pull requests

3 participants