Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitnow@2.3.0 add unwanted entries into kubens and kubectx #12

Closed
erismaster opened this issue Jul 8, 2020 · 2 comments
Closed

Gitnow@2.3.0 add unwanted entries into kubens and kubectx #12

erismaster opened this issue Jul 8, 2020 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@erismaster
Copy link

After updating to 2.3.0, I noticed that I started seeing the following entries in kubens and kubectx (with fzf)

GitNow: Configured and ready to use!
GitNow: Downloading default configuration file...

If I downgrade back to 2.2.0 I do not see these entries. Fzf itself is not getting these extra GitNow entries; I've only noticed it with kubectx and kubens.

@joseluisq
Copy link
Owner

joseluisq commented Jul 9, 2020

Yep, It was due https://github.com/joseluisq/gitnow/blob/2.3.0/functions/__gitnow_config_file.fish#L14
But I was resolved on master branch for now.

So try the master branch until the next release soon.

@joseluisq joseluisq self-assigned this Jul 9, 2020
@joseluisq joseluisq added the bug Something isn't working label Jul 9, 2020
@joseluisq
Copy link
Owner

This issue is resolved on new release 2.3.1.

@joseluisq joseluisq added this to the 2.3.1 milestone Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants