-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remark / Rehype are moving entirely to ESM #93
Comments
Do you have any resources about this change? We will need to investigate. Probably will restrict what node versions are compatible at least. |
Just this thread: wooorm/lowlight#37 (comment) |
I had forgotten about this, but was reminded during this discussion when I tried to upgrade to hljs@11 |
it's currently not possible to use hljs@11 with remark-highlight.js atm :( |
@NullVoxPopuli have you seen how the move to ESM affects Docfy? Regarding highlight, it seems we should be using rehype-highlight moving forward. Have you had success using it? |
once all the dependencies are updated, things should "just work"? (though, seems like there must be a switch to rehype)
haven't tried yet, because I've been waiting for all the dependencies to switch to hljs@11 support |
Is it time for upgrades? looks like rehype-highlight and all sub-deps are using hljs v11 |
@NullVoxPopuli I think we should try to upgrade yes. It would be awesome to get the new features. Any change you have cycles to get that going? |
what does this mean for docfy and docfy config files?
The text was updated successfully, but these errors were encountered: