From 4704977c5a54d1fb3f17125d9364f849dd796456 Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Thu, 20 Jul 2023 14:46:21 +0000 Subject: [PATCH] ci: migrate api golden check to GHA Migrate api golden test to Github Actions --- .circleci/config.yml | 20 -------------------- .github/workflows/ci.yml | 16 ++++++++++++++++ 2 files changed, 16 insertions(+), 20 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 19164f0d0653..7a6c0245f7f4 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -186,26 +186,6 @@ jobs: - run: bazel build --build_tag_filters=-docs-package,-release-package -- src/... - *slack_notify_on_failure - # -------------------------------------------------------------------------------------------- - # Job that runs API golden tests in "tools/public_api_guard". - # This job fails whenever an API has been updated but not explicitly approved through goldens. - # -------------------------------------------------------------------------------------------- - api_golden_checks: - <<: *job_defaults - resource_class: xlarge - environment: - GCP_DECRYPT_TOKEN: *gcp_decrypt_token - steps: - - checkout_and_rebase - - *restore_cache - - *setup_bazel_ci_config - - *setup_bazel_remote_execution - - *yarn_install - - *setup_bazel_binary - - - run: bazel test tools/public_api_guard/... - - *slack_notify_on_failure - # ----------------------------------------------------------------- # Job that runs the e2e tests with Protractor and Chromium headless # ----------------------------------------------------------------- diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f42dd53c4150..c6c559764e53 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -56,3 +56,19 @@ jobs: # it has been merged. if: github.event_name == 'pull_request' run: yarn ng-dev format changed --check ${{ github.event.pull_request.base.sha }} + + api_golden_checks: + runs-on: ubuntu-latest + steps: + - name: Initialize environment + uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@45de46d9ba0e0689b7a846fd31ec9e241807ca71 + with: + cache-node-modules: true + - name: Setup Bazel + uses: angular/dev-infra/github-actions/bazel/setup@45de46d9ba0e0689b7a846fd31ec9e241807ca71 + - name: Setup Bazel RBE + uses: angular/dev-infra/github-actions/bazel/configure-remote@45de46d9ba0e0689b7a846fd31ec9e241807ca71 + - name: Install node modules + run: yarn install --frozen-lockfile + - name: Check API Goldens + run: yarn bazel test tools/public_api_guard/...