Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action for Releasing to NuGet #48

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

michaelosthege
Copy link
Contributor

@michaelosthege michaelosthege commented Jun 29, 2021

I found this to be quite useful for another project. The pipeline is largely copied from https://github.com/michaelosthege/hagelkorn/blob/master/.github/workflows/release.yml#L48-L66

All you need to add is a repository secret in the GitHub repository settings:

grafik

Then you can make new releases by creating them in GitHub. No need to run any CLI things by hand.

Disclaimer: I'm secretely hoping that this helps you @josephwoodward to make a new release, since I'm blocked by #46 that I hope could go away with a new version.

@josephwoodward
Copy link
Owner

Oh fantastic! Thanks for this, it'll definitely help me get changes deployed sooner.

@josephwoodward josephwoodward merged commit 28c5d04 into josephwoodward:master Jun 30, 2021
@michaelosthege michaelosthege deleted the release-action branch June 30, 2021 09:15
@josephwoodward
Copy link
Owner

@michaelosthege Something's wrong with the configuration, I saw seeing the following issue which seems to be to do with the version number:

Version Filepath: src/Serilog.Sinks.Loki/Serilog.Sinks.Loki.csproj
Version Regex: /^\s*<Version>(.*)<\/Version>\s*$/m
Error: 😭 unable to extract version info!
/home/runner/work/_actions/brandedoutcast/publish-nuget/v2/index.js:23
        throw new Error(msg)
        ^

None-the-less, I've manually published a new version of the package and will try and get this working ready for the next release.

Thanks for doing this.

@michaelosthege
Copy link
Contributor Author

Looks like the action has a regex pattern to match the version number, but it does not match 4.0.0-beta1 Release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants