From e7b452f703437cde2f39b38fc49c9c6395c0851d Mon Sep 17 00:00:00 2001 From: Daniel Karrasch Date: Mon, 13 Dec 2021 11:54:54 +0100 Subject: [PATCH 1/2] Remove pivot argument w/ default value in cholesky! --- Project.toml | 2 +- src/algorithms/algorithms.jl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Project.toml b/Project.toml index 2d074d6..ee2b8ba 100644 --- a/Project.toml +++ b/Project.toml @@ -1,6 +1,6 @@ name = "SparseRegression" uuid = "ca6142a6-a6a7-57f5-b674-4a8484b22e92" -version = "0.2.0" +version = "0.2.1" [deps] LearnBase = "7f8f8fb0-2700-5f03-b4bd-41f8cfc144b6" diff --git a/src/algorithms/algorithms.jl b/src/algorithms/algorithms.jl index e126410..8d9d34b 100644 --- a/src/algorithms/algorithms.jl +++ b/src/algorithms/algorithms.jl @@ -268,6 +268,6 @@ Base.show(io::IO, a::LinRegCholesky) = print(io, "LinRegCholesky") function update!(o::SModel, a::LinRegCholesky) copyto!(a.S, a.A) add_ridge!(o, a) - cholesky!(Symmetric(a.S), Val(false)) + cholesky!(Symmetric(a.S)) @views o.β[:] = UpperTriangular(a.S[1:end-1, 1:end-1]) \ a.S[1:end-1, end] end From 28e356a7615df70056c43592732c5d67f8e1ff33 Mon Sep 17 00:00:00 2001 From: Daniel Karrasch Date: Mon, 13 Dec 2021 12:20:58 +0100 Subject: [PATCH 2/2] Update appveyor.yml --- appveyor.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index c1b9d3a..101c114 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -1,7 +1,8 @@ environment: matrix: - - julia_version: 1.0 - - julia_version: 1.1 + - julia_version: 1.2 + - julia_version: 1.6 + - julia_version: 1 - julia_version: nightly platform: @@ -32,4 +33,4 @@ build_script: test_script: - echo "%JL_TEST_SCRIPT%" - - C:\julia\bin\julia -e "%JL_TEST_SCRIPT%" \ No newline at end of file + - C:\julia\bin\julia -e "%JL_TEST_SCRIPT%"