Fix duplicate species in island_tbl bug
#35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…call rm_duplicate_island_species
…duplicate_island_species and change error for warning of oldest and largest clade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #34 by fixing a bug in which species get duplicated in the
island_tblfrom extraction (extract_island_species()) if they are nested from the ancestral state reconstruction.A new function,
rm_duplicate_island_species()is added to the package which is called inextract_island_species()to remove any duplicated species after the extraction and before theisland_tblobject is returned to the user.rm_duplicate_island_species()contains two algorithms for handling duplicate species. The"split"algorithm removes the duplicate species from the oldest clade, leaving two colonists, the"group"algorithm removes the youngest clade, leaving a single larger clade. TheNEWS.mdis updated with a description of the new functionality.Unit tests are added for
rm_duplicate_island_species().