Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18 better organize generated power files #20

Merged
merged 10 commits into from
Feb 3, 2023

Conversation

JeremyNison
Copy link
Collaborator

@JeremyNison JeremyNison commented Feb 2, 2023

Implementation of the new result files hierarchy, as discussed in issue #18 .

The new class ResultTreeManager is responsible for creating the required folders and provide methods for easily getting the needed filepaths when writing data. Particularly, this class is created in the Agent and is passed as an argument to the existing MonitoringHandler and ShutdownHandler class. Those classes uses it's methods to write data at the right place.

The methods saveResults in MonitoringHandler and in ShutdownHandler has also been refactored : the filepath creation has been extracted and is now independant from those methods, allowing to use the new ResultTreeManager more easily.

Finally, in the ShutdownHandler, the writing of the methods consumption evolution files has been refactored. It is now done with the saveResult method, instead of writeConsumptionEvolution that became obselete as all the folder creation job is now performed by the create() method of ResultTreeManager.

This pull request closes #18 .

@JeremyNison JeremyNison self-assigned this Feb 2, 2023
@JeremyNison JeremyNison linked an issue Feb 2, 2023 that may be closed by this pull request
@JeremyNison
Copy link
Collaborator Author

For the moment, the name of the folder corresponding to an execution does not match the template app_name-PID-start_timestamp as described in #18 , as getting the executed application name looks tricky. The app name is for the moment replaced by the string run, as in this example :

resfolderexample

@JeremyNison
Copy link
Collaborator Author

JeremyNison commented Feb 3, 2023

We decided not to include the app name in the generated result folder, and removed the "run" keyword. From now on, the result folder generated for each execution is named like this : PID-start_timestamp.

@adelnoureddine adelnoureddine merged commit e6d84cb into develop Feb 3, 2023
@adelnoureddine adelnoureddine deleted the 18-better-organize-generated-power-files branch February 3, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better organize generated power files
2 participants