Added stack-monitoring-sample-rate to agent properties #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @MagielBruntink, this seems all fine to me but I have to check it through locally so everything is working fine. |
MagielBruntink
force-pushed
the
add-stack-monitoring-sample-rate-property
branch
from
fb9d514
to
aad6e97
Compare
|
@adelnoureddine re-based and re-targetted the PR. |
adelnoureddine
approved these changes
Sep 27, 2023
|
Thanks, I'll merge your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this PR: in some use cases it is preferable to have a more accurate JVM stack monitoring than the default 10 ms interval provides. Therefore this PR adds the
stack-monitoring-sample-rateproperty so the sample rate/interval can be set by the user via config.properties. Allowable values are checked to be within [1,1000] range, defaulting to 10 ms when not set.