Negative values fix #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot @kifetew. I"ll check your proposed modification in the coming days on Linux and RPi, and merge after that if all goes well. |
| @@ -247,47 +258,91 @@ private Map<Thread, Map<CallTree, Integer>> extractCallTreesStats(Map<Thread, Li | |||
| return stats; | |||
| } | |||
|
|
|||
| // /** | |||
| // * Updates the CPU times for each Thread. | |||
There was a problem hiding this comment.
I'd rather not comment existing methods, but modify them (or remove), as it's easier to see the changes with your commit
| * @param totalThreadsCpuTime the CPU time used by all the monitored threads | ||
| * @param processEnergy the energy consumed by the process | ||
| * @return for each PID, the percentage of CPU time used by the associated thread | ||
| * |
There was a problem hiding this comment.
Could you add a description of the method in the javadoc? As you merged two methods together, you can just reuse both descriptions into one.
adelnoureddine
approved these changes
Jan 22, 2024
|
Thanks @kifetew, I'll merge your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes related to negative values