From 1f0b6fc8d8e6b9beaf4bdae264ad33ced248c418 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Fri, 29 Sep 2023 17:23:52 +0200 Subject: [PATCH] [api] remove CpuFeatures::SupportedFeatures() from CachedDataVersionTag() The code cache should be CPU-independent, we also do not actually check this during the deserialization of code cache, so there is no need to impose this in the embedder-facing CachedDataVersionTag() API. Refs: https://github.com/nodejs/node/issues/42566#issuecomment-1735862123 Change-Id: Ia1d677b949050add961af6fbf62c44342c061312 --- src/api/api.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/api/api.cc b/src/api/api.cc index 77c9238e787a..4538ee018ebe 100644 --- a/src/api/api.cc +++ b/src/api/api.cc @@ -2884,9 +2884,8 @@ MaybeLocal ScriptCompiler::CompileModule( } uint32_t ScriptCompiler::CachedDataVersionTag() { - return static_cast(base::hash_combine( - internal::Version::Hash(), internal::FlagList::Hash(), - static_cast(internal::CpuFeatures::SupportedFeatures()))); + return static_cast(base::hash_combine(internal::Version::Hash(), + internal::FlagList::Hash())); } ScriptCompiler::CachedData* ScriptCompiler::CreateCodeCache(