Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic retries during MPU with CSE breaks files #284

Closed
tjcelaya opened this issue Jul 12, 2017 · 0 comments
Closed

Automatic retries during MPU with CSE breaks files #284

tjcelaya opened this issue Jul 12, 2017 · 0 comments
Assignees

Comments

@tjcelaya
Copy link
Contributor

tjcelaya commented Jul 12, 2017

We've discovered an issue where automatic retries triggered by the Apache HTTP Client library ruins the state of the CipherOutputStream and HmacOutputStream objects used when resending the same part. Fixing this would require snapshotting the state of the EncryptionState object in EncryptedMultipartUpload and only updating the state of encryption and digest objects if the part is uploaded successfully. Attached screenshot shows how a manually terminated request is followed by an automatic retry which corrupts the file.

screen shot 2017-07-11 at 10 48 47 am

(click to zoom)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant