Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoApiServersAvailable is not present in MantaErrorCode enums #470

Closed
dekobon opened this issue Jan 26, 2019 · 4 comments
Closed

NoApiServersAvailable is not present in MantaErrorCode enums #470

dekobon opened this issue Jan 26, 2019 · 4 comments
Assignees

Comments

@dekobon
Copy link
Contributor

dekobon commented Jan 26, 2019

There is no value for NoApiServersAvailable in the MantaErrorCode enum.

@dekobon
Copy link
Contributor Author

dekobon commented Jan 26, 2019

Upon inspection, this error code comes from muppet and all of the muppet error codes haven't been added to the enum.

The files in this repository ending in .http should be inspected for error codes and those codes should be added to the enum.

@indianwhocodes
Copy link
Contributor

indianwhocodes commented Jan 30, 2019

After further reviewing this issue and consulting with @IanWyszynski and @jclulow, I found out that the MantaErrorCode enum should include the 408-Error from this repository ending in .http. Also, 400 and 503 have already been included in the enum values:BAD_REQUEST_ERROR and SERVICE_UNAVAILABLE_ERROR here.

Furthermore, enum values corrected for:

Additional Values Edited by referring source file.

Values added for:

Other Values Added by referring source file.

@dekobon
Copy link
Contributor Author

dekobon commented Feb 9, 2019

Additionally, I discovered that the error code: SnaplinksDisabledError has also not been added to the list of error codes.

@indianwhocodes
Copy link
Contributor

Being fixed by PR #501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants