-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more tests to tst.context.js #56
Comments
I don't think I follow the cases that the new tests are intended to address. Could you maybe add some comments explaining what the test is doing? Also, is there a reason to drop the isError check? |
I dropped the |
Thanks for the update! I moved the discussion to the CR. In summary, I prefer to keep the |
I've run the test suite using several different versions of node:
Looking at the results of the runs:
|
Reviewed by: David Pacheco <dap@joyent.com> Approved by: David Pacheco <dap@joyent.com>
While looking at
tst.context.js
, I realized that it could do with some better tests.The text was updated successfully, but these errors were encountered: