node_modules lookup optimization breaks certain project structures

[mafintosh]

There is a problem with the node_modules lookup optimization.
The problem is it breaks the following simple project structure

~/projects/node_modules/    // a general purpose folder for all modules
~/projects/node_modules/general.js
~/projects/foo
~/projects/foo/node_modules/bar.js

now bar.js cannot do require('general'); because of the optimization.

Since the require is mostly being done a program boot time it seems like a bad trade-off to not allow the above structure because of an optimization.

[isaacs]

So then, you're proposing that this bit be removed?

Second, if the file calling `require()` is already inside a `node_modules`
hierarchy, then the top-most `node_modules` folder is treated as the
root of the search tree.

I have no problem with that. Wanna try a patch? It should be a pretty simple change to the Module._nodeModulePaths method in lib/module.js. (And the doc change, of course.)

[mafintosh]

Yes - that's exactly what I mean.

I'll try to do the patch.

[mafintosh]

I've created a patch that fixes the issue. https://gist.github.com/1023916

[isaacs]

Awesome. Sorry, I forgot to mention, can you also sign the node CLA? http://nodejs.org/cla.html

Patch looks fine, otherwise :)

[mafintosh]

Great :) I signed the CLA.

[isaacs]

Landed on 39246f6. Thanks!