This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Properly respond to HTTP HEAD requests during end(body) hot path #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During write(), _hasBody is checked to make sure a body is allowed -- this is now also checked during end(body) when write() isn't used.
Instead of simply clearing data, check _hasBody earlier to avoid sending cruft when chunkedEncoding is used.
|
I squashed these commits into a single commit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During write(), _hasBody is checked to make sure a body is allowed -- this is now also checked during end(body)'s hot path when write() isn't used.
Without this patch, it's possible that res.end("foo") can send a malformed HEAD response that http_parser rejects.
Includes a new test.