Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

remove http.cat #1447

Closed
mikeal opened this issue Aug 3, 2011 · 5 comments
Closed

remove http.cat #1447

mikeal opened this issue Aug 3, 2011 · 5 comments
Labels

Comments

@mikeal
Copy link

mikeal commented Aug 3, 2011

http.cat has been noted as needing to be deprecated for a while.

at the moment, it's an entire different code path from the rest of the http client logic.

the biggest task when removing it is just getting the unittests to stop using it.

@isaacs @ry

@isaacs
Copy link

isaacs commented Aug 3, 2011

I approve. Yes, the biggest change is to update all the unit tests. If we really want to remove this from the API, we could move it into tests/common.js.

@mikeal
Copy link
Author

mikeal commented Aug 3, 2011

ideally, all of the tests hit our real HTTP API. http.cat as the only thing I didn't shim in the re-write of the client because it was going to be deprecated anyway.

@ry
Copy link

ry commented Aug 3, 2011

LGTM

@mikeal
Copy link
Author

mikeal commented Aug 15, 2011

can we get this merged?

@bnoordhuis
Copy link
Member

Thanks, merged in 584ae7b.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants