Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

added additional properties to getPeerCertificate with test case #1612

Closed
wants to merge 2 commits into from
Closed

added additional properties to getPeerCertificate with test case #1612

wants to merge 2 commits into from

Conversation

niclashoyer
Copy link

Added additional properties to getPeerCertificate, now includes
subjectAltName, Exponent and Modulus (FOAF+SSL friendly).

Patch written by Nathan,
http://groups.google.com/group/nodejs/browse_thread/thread/1d42da4cb2e51536

I also added a test case based on test-https-simple to test the new attributes.

@koichik
Copy link

koichik commented Aug 31, 2011

@niclashoyer - Thanks! This time, can you sign the CLA? :)
And can I modify the patch?

  1. Apply @pquerna's suggestion.
  2. Fix BIOs usage.

@niclashoyer
Copy link
Author

just signed it.

Of course, please modify the patch :)

@bnoordhuis
Copy link
Member

Use NID_subject_alt_name: da3bc23

However, valgrind is complaining wildly on the test/simple/test-https-foafssl.js test (with and without da3bc23). Needs further investigating.

@koichik
Copy link

koichik commented Aug 31, 2011

Fix BIO's usage: 937dc27

@koichik
Copy link

koichik commented Sep 2, 2011

@bnoordhuis - With 937dc27, valgrind isn't complaining.

before:

==8852== ERROR SUMMARY: 4 errors from 4 contexts (suppressed: 4 from 4)

after:

==8931== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 4 from 4)

Can I merge all together?

@bnoordhuis
Copy link
Member

@koichik: yes, go ahead.

@koichik koichik closed this in 28a9084 Sep 2, 2011
@koichik
Copy link

koichik commented Sep 2, 2011

@niclashoyer - Thanks for your contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants