This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Diffie-Hellman support in crypto module #573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test? |
…rameters similar to other crypto functions
|
Let me know if you need anything else. |
…, added tests, updated documentation
|
Sorry, can you please fix the style. In particular the long lines: Please start with this patch: https://gist.github.com/815320
|
|
Same commit as patch ready for application on top of your rebased patch: https://gist.github.com/817133. Or, you can cherry-pick the last commit (which was cherry-picked onto master from a branch started from your rebased patch). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented Diffie-Hellman support in the crypto module, utilizing OpenSSL. Would you consider the patch for inclusion? I am uncertain as to whether you require more information than this pull request. If so, please let me know.