https server / req.socket.socket

[fabrizim]

When running an https server with express, I noticed that when I lit up a logger and tried to print the remoteAddress, it was printing 'undefined'. After some investigation, I found that the socket object in the request was missing the remoteAddress property. I also found that req.socket had a socket property as well.

To work around this for logging purposes, I just added my own little middleware function:

function(req,res, next){
    if( req.socket.socket ){
        req.socket.remoteAddress = req.socket.socket.remoteAddress;
    }
    next();
};

However, I think this indicates a larger problem that may affect other code expecting missing properties from the req.socket object within the https module.

Should there be consistency between the servers created with http and https?

[sh1mmer]

HTTPS uses the TLS module which provides the CleartextStream class. This is a stream implementation with a socket in it. This is why you see this behaviour. It's expected, but I agree it is a little strange. I'm going to mark this as a feature request to get some discussion about it.

[koichik]

@ry @bnoordhuis - Can you review?

[bnoordhuis]

@koichik: LGTM

[koichik]

@bnoordhuis - Thanks, merging.

[koichik]

@fabrizim - Thanks for the report.

[fabrizim]

Glad I could help - thanks for looking into it and making things modules more consistent.

[sh1mmer]

@fabrizim do you have a test case for this? Can you replicate with HEAD?