This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Drop vestigial process.installPrefix, node --vars, NODE_CFLAGS and NODE_PREFIX
#3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d NODE_PREFIX Also removed unused node_config.h.in (replaced with config.gypi a while back).
|
LGTM. Other committers? |
|
LGTM |
|
Thanks Trent, landed in 196207c. |
|
Thanks! |
|
updated https://github.com/joyent/node/wiki/API-changes-between-v0.6-and-v0.8 "Removed:" section |
iarna
pushed a commit
to npm/npm
that referenced
this pull request
Jan 6, 2016
process.installPrefix was removed here: nodejs/node-v0.x-archive#3483. It was announced here: https://github.com/jhnns/node/wiki/API-changes-between-v0.6-and-v0.8. PR-URL: #10990 Credit: @jeffmcmahan
iarna
pushed a commit
to npm/npm
that referenced
this pull request
Jan 7, 2016
process.installPrefix was removed here: nodejs/node-v0.x-archive#3483. It was announced here: https://github.com/jhnns/node/wiki/API-changes-between-v0.6-and-v0.8. PR-URL: #10990 Credit: @jeffmcmahan
zkat
pushed a commit
to npm/npm
that referenced
this pull request
Jan 19, 2016
process.installPrefix was removed here: nodejs/node-v0.x-archive#3483. It was announced here: https://github.com/jhnns/node/wiki/API-changes-between-v0.6-and-v0.8. PR-URL: #10990 Credit: @jeffmcmahan
This was referenced Jan 31, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed unused node_config.h.in (replaced with config.gypi a while
back).
If/when this is pulled in, I can update https://github.com/joyent/node/wiki/API-changes-between-v0.6-and-v0.8 to mention the dropped
process.installPrefix.Notes:
node --varsworked in node 0.4.x.node --varsprints nothing and exits 0.