Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugo v0.101 breaks the HOMEPAGE link. #230

Closed
MikiVanousek opened this issue Jun 25, 2022 · 4 comments
Closed

Hugo v0.101 breaks the HOMEPAGE link. #230

MikiVanousek opened this issue Jun 25, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@MikiVanousek
Copy link
Contributor

What happened?

When building the site with Hugo v0.99 everything works as expected. But when Hugo v0.101 is used, the link to the home of the page does not lead to the desired ./webiste, but to ./. All other links work as expected. The issue was resolved by switching to the dev branch.

Theme version

v2.2.3

Hugo version

v0.101

What browsers are you seeing the problem on?

Firefox, Chrome

Relevant Hugo log output

No response

@MikiVanousek MikiVanousek added the bug Something isn't working label Jun 25, 2022
@MikiVanousek
Copy link
Contributor Author

@Yawar5

@jpanther
Copy link
Owner

Thanks for the report. Yes, the dev branch contains a change that I suspect is what has fixed this issue - 971e8b6.

I guess something changed in the way Hugo interprets any paths that start with a forward slash as a local path and so using "/" to link to the homepage breaks the way it generates the URL.

The fix will be included in the next release.

@MikiVanousek
Copy link
Contributor Author

Considering that GH pages uses Hugo v0.101, everyone's page will be broken after the first push. For this reason, I think it would be wise to release the update ASAP, even if it would be the only change in the next release.

The error was encountered by my friend, who is not that tech-savvy. He spent a considerable amount of time trying to fix it. Encountering an issue like this while first setting up your website could cause someone like him to abandon the theme altogether.

I would even consider putting a temporary announcement into the README / documentation, to let people who are struggling with this issue know you can fix it by updating the theme.

@MikiVanousek MikiVanousek changed the title Hugo v0.101 breaks the website on stable, but works on develop. Hugo v0.101 breaks the HOMEPAGE link. Jun 26, 2022
@jpanther
Copy link
Owner

The update will be out very soon and I'm committing a change that specifically calls out this issue in the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants