Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit sorting of trades by name within a config when randomization is off #204

Open
jpenilla opened this issue Aug 24, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jpenilla
Copy link
Owner

As of 1.8.2 trades within a config are sorted by name when randomization is off. This was done to make things consistent with the trade list GUI. However, when editing the config files directly this is not always desired. With this in mind, I think this change should be reverted, and the GUI should be adjusted to show the raw order from the config as well. I don't remember whether Bukkit config API preserves the order of maps correctly, if not a switch to Configurate may be needed. A nice extra might be a mechanism to sort/reorder trades from within the GUI.

@jpenilla jpenilla added the enhancement New feature or request label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant