Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Global/Per Player limit option to trades #69

Open
TheCashFire opened this issue Jul 8, 2021 · 1 comment
Open

Add Global/Per Player limit option to trades #69

TheCashFire opened this issue Jul 8, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@TheCashFire
Copy link

Is your feature request related to a problem? Please describe.
(A clear and concise description of what the problem is. Ex. I'm always frustrated when [...])

To start, the plugin works fantastically. No bugs that I've found so far. The only frustration I have is when the trader has his stock, they share a GLOBAL item limit instead of a PER PERSON one, and there is no way to change/choose which one you want.

This means that if the trader is selling one stick for one emerald, and I want to limit that to one per person, per trade rotation (for example, trades rotate every hour, which would mean one trade of that type per hour before the trade runs out), the only way to do this currently is to limit the Wandering Trader to sell only one of that item before the limit is reached. Currently, that sets the global limit, so player A can buy that emerald, but player B then finds that the trader has run out of stock, and it remains that way of the next hour.

Describe the solution you'd like

My solution is simple: Add in a config option that defines (either on a per trade basis or a per config basis) that a certain trade/config has a stock limit on a per person/global basis. This way, player A and player B can both only purchase one emerald per hour for that trade before it refreshes.

(The maxUses: ## variable currently is limited to global uses. I suggest there also be a variable like useLimit: global / person
This would easily define what the limit is, and what the limit is for, instead of assuming it is a global limit.)

Describe alternatives you've considered

This was the only solution I could come up with and it was beyond me to code. I have not found any other way of making this method possible.

Additional context
Add any other context or screenshots about the feature request here.

If this is already implemented, my bad, let me know and I'll remove the post. But I could not find a way to mimic this currently. Please and thank you for this, I hope it gets added quickly! :)

@TheCashFire TheCashFire added the enhancement New feature or request label Jul 8, 2021
@TheCashFire TheCashFire reopened this Jul 8, 2021
@TheCashFire
Copy link
Author

New to creating GitHub tickets. Disregard open/close.

@TheCashFire TheCashFire changed the title [Feature Request] Add Global/Per Player limit option to trades Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant