-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pushover now supports image attachments - would be grand to add this to mqttwarn #284
Comments
Make it happen, Ben! :-) |
Dear Ben and Jan-Piet, we just created the basic mqttshot program for publishing messages containing text and a single image to the MQTT bus. It currently has these properties:
Please consider this as a proposal about a convention of how to send basic messages containing images over MQTT. We will be happy if this can help anyone tackling the proposed implementation for mqttwarn/pushover. Cheers, |
That looks very good, Andreas. I think for mqttwarn we'd need to be able to configure the JSON element containing the image data, but otherwise that's a fine job. FWIW, I fully agree with not sending binary images: base64-encoding fits the bill perfectly. |
I use a similar approach for images over mqtt but prepend the base64 string with a datauri: Please add at least a field with filetype for that use case |
I think I have updated the pushover to support this. Works with json payloads, it can accept either an imageurl parameter which it will download the image and include it, or a base64 encoded image. My development machine (with github) is out of action today, but I'll try to add the code in the next day or two. regarding @amotl above, I use "image" as the binary base64 image, and "imageurl" for an image to be downloaded, as it looks like they use the same tag. |
Is this in the right place? It doesn't show under your repo for pull requests: psyciknz#1 |
The PR for this is being addressed in #304 |
Implemented via #304 |
https://updates.pushover.net/post/170043375237/pushing-images-with-pushover-30
The text was updated successfully, but these errors were encountered: