modular build builds in concurrent batches
#2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8ef5627 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cristiano-belloni
changed the title
modular build builds in concurrent batches
cristiano-belloni
requested review from
AlbertoBrusa,
benpryke,
sgb-io and
steveukx
AlbertoBrusa
approved these changes
Apr 14, 2023
sgb-io
reviewed
Apr 14, 2023
| const concurrency = parseInt(concurrencyLevel, 10); | ||
|
|
||
| // If not a number or a negative number, bail out with an error. | ||
| if (isNaN(concurrency) || concurrency < 0) { |
There was a problem hiding this comment.
What happens if someone provides a big number? Let's say they typo a couple zeros on the end and put 600. Is this fine or do we need an upper boundary?
There was a problem hiding this comment.
What happens if someone provides a big number? Let's say they typo a couple zeros on the end and put
600. Is this fine or do we need an upper boundary?
It's fine, because:
- in practice, the number of things a project can build concurrently at a given stage will be much less than 600 (even if the project has 600 packages, they will be probably interdependent and generate a number of smaller concurrent subsets)
- the worst that can happen is that Modular is slow or goes out of memory, in which case the user can just rectify their command
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables batched algorithms for
modular buildwith a custom max concurrency level. Build jobs that can be parallelised are executed in consecutive--concurrencyLevel-long job parallel batches, that are run one after the other until exhaustion.--concurrencyLevellevel is a new user option that defaults to the number of logical CPUS in the machine.This also fixes a bug in
modular selectwhere the parallel dependency array can sometimes have holes.