Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-save test code #180

Open
ceball opened this issue Jun 15, 2020 · 2 comments
Open

Auto-save test code #180

ceball opened this issue Jun 15, 2020 · 2 comments
Labels
lang: javascript PRs or issues related to Javascript type: bug Concrete, reproducible bugs
Milestone

Comments

@ceball
Copy link
Collaborator

ceball commented Jun 15, 2020

When you edit a cell, you don't have to click save. If you edit a test, then click away without saving, your test is lost :(

@ceball ceball added bug part: cell tests Relating to cell testing component labels Jun 15, 2020
@ceball ceball added this to the 0.3 milestone Jun 15, 2020
@ceball ceball added jupyterlab_celltests and removed part: cell tests Relating to cell testing component labels Jun 15, 2020
@timkpaine
Copy link
Collaborator

timkpaine commented Aug 20, 2020

you actually do have to save if you edit a cell, unless the autosave picks it up. if you edit a cell and ctrl-r the page, your edits will be gone. but we should support ctrl-s shortcut and we can setup a timer to periodically save the tests to the notebook (where they'll be picked up by autosave).

@ceball
Copy link
Collaborator Author

ceball commented Aug 21, 2020

Ah, I wasn't clear. It's worse than that :)

If you edit a cell, and then you go click in some other cell, your edits in the first cell aren't lost. (Yes, ultimately you have to save the notebook, but that's not what I'm talking about.)

If you edit a test, then you click in some other cell (e.g. to edit another test), your edits to the first test are immediately lost (if you didn't click save in the test editor).

@timkpaine timkpaine added type: bug Concrete, reproducible bugs lang: javascript PRs or issues related to Javascript and removed bug labels Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang: javascript PRs or issues related to Javascript type: bug Concrete, reproducible bugs
Projects
None yet
Development

No branches or pull requests

2 participants