-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support file://
url string path
#1022
Comments
Sorry, just trying to make sure I understand correctly. You're proposing that fs-extra wraps all |
Yes |
I don't particularly like the fact that we currently wrap |
Also cc @jprichardson @manidlou @JPeer264 for thoughts here. |
I agree with @RyanZim, I don't see an absolute necessity for it right now. |
NodeJS dose not really support
file://<path>
url strings, they need to be converted into URL instances first and formost to be supported.in the lights of new ESM modules, ppl turn more towards the help of
import.meta.url
and also the newimport.meta.resolve('./worker.js')
but this two dose only return file-url-string,not a url instance.
the lack of
file://
strings support in NodeJS is problematic and annoying for many developers.it leads to unconventional inovation that makes the NodeJS creator inventing even more non standard
import.meta
propertiesthat i do not think should be added.
wintercg/proposal-minimum-common-api#50
Here is a quick and dirty solution that i propose: fsURL
The text was updated successfully, but these errors were encountered: