Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance regression on 0.7.0 #119

Closed
norio-nomura opened this issue Dec 13, 2015 · 3 comments
Closed

Performance regression on 0.7.0 #119

norio-nomura opened this issue Dec 13, 2015 · 3 comments

Comments

@norio-nomura
Copy link
Collaborator

Sorry, I have introduced performance regression by #111.
I think func byteRangeToNSRange(start start: Int, length: Int) -> NSRange? needs caching result.
@norio-nomura
Copy link
Collaborator Author

Or caching results of func indexOfByteOffset(offset: Int) -> Int?.

@norio-nomura
Copy link
Collaborator Author

I'm sorry, the performance regression does not caused by #111.
But 0.7.0 is so slow.
e.g. on linting KeychainAccess by SwiftLint-0.5.0

This was referenced Dec 13, 2015
Merged
Merged
@norio-nomura
Copy link
Collaborator Author

I thought that the performance regression has been introduced by realm/SwiftLint#247 and filed PRs (realm/SwiftLint#263, #120 and #122) for resolving that.
SwiftLint 0.5.1 is still slower than 0.4.0, but now I close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@norio-nomura