Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address block support #430

Closed
haharu opened this issue Aug 21, 2017 · 2 comments
Closed

Address block support #430

haharu opened this issue Aug 21, 2017 · 2 comments

Comments

@haharu
Copy link

haharu commented Aug 21, 2017

Hello,

I need a new type of block with element <address> as wrapper

such like <span> I am currently on the way to <address> 1600 Amphitheatre Parkway, Mountain View, CA, 94043 </address>.<span>

In order to specify which part of text should be treated as address (for mobile app)

I will send pr to both draftjs-to-html and this repo, probably should also modify draftjs-utils according to this issue.
facebookarchive/draft-js#1211

but I cannot decide the style in editor, so I do need your help in draftjs-utils @jpuri

Thanks!

@jpuri
Copy link
Owner

jpuri commented Aug 21, 2017

Hey @haharu ,

I was looking at this: https://www.w3.org/TR/html4/struct/global.html#h-7.5.6
Looks like address is not a block level tag. I do not think we should include it in blocks.

I would rather prefer to create a custom toolbar option for a tag like this.

@haharu
Copy link
Author

haharu commented Aug 22, 2017

hi @jpuri,

thanks for your advice, I will close this issue and pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants