-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PEP484 type hints #44
Comments
Just realised that Pypy doesn't appear to support type hints :( https://doc.pypy.org/en/latest/faq.html#would-type-annotations-help-pypy-s-performance Would that be a blocker for this issue? |
Hi, thanks for the proposal and the PR! I've been thinking about adding type hints myself as well :)
I was checking the Travis logs for your PR and it looks like the Pypy build is failing to install
|
I've skipped mypy on pypy3 tox run, so it should all be fine on the PR now. |
Thanks, @wwuck! This is included in v0.5.0. |
It looks like you added type hints (fantastic), but forgot to add the I'd highly recommend check-manifest to avoid this in the future. Maybe in a pre-commit check or something. docs. |
Proposal to add PEP484 type hints and related PEP561 packaging information to inflection. Since the lowest support python3 here appears to be 3.5, we can just use typing library directly without using type hint comments.
The text was updated successfully, but these errors were encountered: