Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scalars_or_empty is undocumented #1840

Closed
muhmuhten opened this issue Feb 23, 2019 · 2 comments
Closed

scalars_or_empty is undocumented #1840

muhmuhten opened this issue Feb 23, 2019 · 2 comments

Comments

@muhmuhten
Copy link
Contributor

muhmuhten commented Feb 23, 2019 •
edited
Loading

Actually, can we get rid of it? It's kind of misnamed (empty means something else...) and it's only used for one test (for the streaming parser 5bfb978), which isn't even testing it specifically.
@nicowilliams
Copy link
Contributor

Sure, let's get rid of it.

@muhmuhten muhmuhten mentioned this issue Feb 26, 2019
Merged
@nicowilliams
Copy link
Contributor

Removed in #1845.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicowilliams @muhmuhten