-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUSTSEC-2020-0071: Potential segfault in the time crate #86
Comments
Lines 124 to 126 in 3584695
and we do not use the affected functions in the advisory. Regardless, there is a pending PR upstream on both chrono and time, so a fix is imminent and will be applied to eliminate this GitHub bot security advisory. |
Stale issue message |
Once this PR is merged - chronotope/chrono#639, this will take care of this issue. |
This remains a false positive. Regardless, chrono 0.4.20-rc.1 is now a release candidate, Once its released, we'll use it and close this advisory. |
We are now using chrono 0.4.20 - which no longer depends on the vulnerable parts of the time 0.1.x versions - which is the cause of this security advisory. Once chrono 0.5.0 is released, where time 0.1.x will be removed, this advisory will no longer be triggered during a cargo audit. |
Stale issue message |
time
0.1.43
>=0.2.23
=0.2.0,=0.2.1,=0.2.2,=0.2.3,=0.2.4,=0.2.5,=0.2.6
Impact
Unix-like operating systems may segfault due to dereferencing a dangling pointer in specific circumstances. This requires an environment variable to be set in a different thread than the affected functions. This may occur without the user's knowledge, notably in a third-party library.
The affected functions from time 0.2.7 through 0.2.22 are:
time::UtcOffset::local_offset_at
time::UtcOffset::try_local_offset_at
time::UtcOffset::current_local_offset
time::UtcOffset::try_current_local_offset
time::OffsetDateTime::now_local
time::OffsetDateTime::try_now_local
The affected functions in time 0.1 (all versions) are:
at
at_utc
Non-Unix targets (including Windows and wasm) are unaffected.
Patches
Pending a proper fix, the internal method that determines the local offset has been modified to always return
None
on the affected operating systems. This has the effect of returning anErr
on thetry_*
methods andUTC
on the non-try_*
methods.Users and library authors with time in their dependency tree should perform
cargo update
, which will pull in the updated, unaffected code.Users of time 0.1 do not have a patch and should upgrade to an unaffected version: time 0.2.23 or greater or the 0.3. series.
Workarounds
No workarounds are known.
References
time-rs/time#293
See advisory page for additional details.
The text was updated successfully, but these errors were encountered: