Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to find node on an unmounted component error with release 0.39.4 #2151

Closed
4 of 5 tasks
ferencbenko-wo opened this issue Mar 18, 2022 · 9 comments
Closed
4 of 5 tasks
Labels

Comments

@ferencbenko-wo
Copy link

Check that this is really a bug

  • I confirm

Reproduction link

https://codesandbox.io/s/wild-fire-c3dsz1?

Bug description

The newest release is completely unusable for me, since I get the ,,Unable to find node on an unmounted component" error.
Reverting to 0.39.3 solves the issue.

Expected Behavior

No response

Actual Behavior

No response

react-big-calendar version

0.39.4

React version

16.14.0

Platform/Target and Browser Versions

Microsoft Edge 99.0.1150.36

Validations

  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a react-big-calendar issue and not an implementation issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
@nichtsam
Copy link

Here is an example for the error:
https://stackblitz.com/edit/nextjs-gtrsss

@cutterbl
Copy link
Collaborator

I verify this error, when using React 16.14.0. I do not receive the error when using 17.0.2. Are you unable to upgrade to 17.0.2?

@ferencbenko-wo
Copy link
Author

ferencbenko-wo commented Mar 22, 2022

I could, but rather reverted the calendar version to 0.39.3 for a quick fix, since I already wasted too much time figuring out why the calendar isn't working

@runofthemillgeek
Copy link
Contributor

runofthemillgeek commented Mar 24, 2022

@nichtsam @ferencbenko can you folks try 0.39.7? Should fix this issue. @nichtsam in your example, pass an empty events={[]} prop as well.

Edit: I meant to say 0.39.7

@nichtsam
Copy link

@nichtsam @ferencbenko can you folks try 0.39.7? Should fix this issue. @nichtsam in your example, pass an empty events={[]} prop as well.

Edit: I meant to say 0.39.7

Seems to get pass that error, but another error occurs:
TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))

Example below ( events added )
https://stackblitz.com/edit/nextjs-3bcjzv

@BrianMehrman
Copy link

@nichtsam @ferencbenko can you folks try 0.39.7? Should fix this issue. @nichtsam in your example, pass an empty events={[]} prop as well.

Edit: I meant to say 0.39.7

First I would just like to thank you two for working on this bug. I ran into this on Friday morning and was so ecstatic to see someone else was having the same issue.

I just updated to 0.39.7 and can confirm that the change @sangeeth96 made has fixed the error for me and my simple implementation of your calendar library.

Thank you again @sangeeth96 for getting this fix out for all of us who use your library.

@nichtsam I was taking a look at your example. Is there an event attribute for the Calendar component. I found the calendar worked if you changed event={{}} to events={[{}]}

https://stackblitz.com/edit/nextjs-pfmgz1?file=pages/index.js

@nichtsam
Copy link

@nichtsam @ferencbenko can you folks try 0.39.7? Should fix this issue. @nichtsam in your example, pass an empty events={[]} prop as well.
Edit: I meant to say 0.39.7

First I would just like to thank you two for working on this bug. I ran into this on Friday morning and was so ecstatic to see someone else was having the same issue.

I just updated to 0.39.7 and can confirm that the change @sangeeth96 made has fixed the error for me and my simple implementation of your calendar library.

Thank you again @sangeeth96 for getting this fix out for all of us who use your library.

@nichtsam I was taking a look at your example. Is there an event attribute for the Calendar component. I found the calendar worked if you changed event={{}} to events={[{}]}

https://stackblitz.com/edit/nextjs-pfmgz1?file=pages/index.js

Oops, my bad, misread the comment!
didn't put much attention on it since it wasn't causing the original issue.

does events not accept undefined anymore?
I think it did accepted before, so does the typing suggest, but it seems to break with undefined provided.

@runofthemillgeek
Copy link
Contributor

@nichtsam you're right, in 0.39.3, there was only a warning but when I switch to Week/Day/Agenda, things still break. Maybe there's better error reporting that can be done here but that's probably a different issue/PR.

cc @cutterbl

@ferencbenko-wo
Copy link
Author

It's working now with 0.39.7. Thank you @sangeeth96!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants