Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering bug in week and month views #36

Closed
okcompute opened this issue Feb 4, 2016 · 7 comments
Closed

Rendering bug in week and month views #36

okcompute opened this issue Feb 4, 2016 · 7 comments

Comments

@okcompute
Copy link
Contributor

Hi,

The row segment are rendered too short when I create an event spanning over an entire month:

2016-02-04 14_28_29-renderingbug

This behavior is also reproduced in the week view.

I have tried to look up the code for the possible error but I could not find it.

I produced this bug with version 0.9.8

I use react 0.14.7

My browser is chrome version 48.0.2564.97

If you don't have time to look it up, I take any pointer to help out :)

Thank you for this superb react component!

@adamcharnock
Copy link

I'm also encountering this too (seen in versions 0.9.7 & 0.9.8). Any suggestions very welcome :-)

@adamcharnock
Copy link

Changing this line to the following seems to (kind of) solve the problem:

let slots = dates.diff(first, last, 'day') + 1; // The '+ 1' is new

This is pretty hacky and I'm quite sure it isn't the correct solution. I suspect it is more to do with how the last day of the week is being specified, or something in that vague region.

@antoinerousseau
Copy link
Contributor

I'm having the same issue when the specified culture's week ends on a Sunday rather than a Saturday.

E.g. with culture="fr":

capture d ecran 2016-04-02 15 16 35

And with culture="en":

capture d ecran 2016-04-02 15 16 21

Using v0.9.8

@antoinerousseau
Copy link
Contributor

Actually the bug is visible on the demo pages!
http://intljusticemission.github.io/react-big-calendar/examples/index.html

@antoinerousseau
Copy link
Contributor

Looks like this is trying to resolve a similar bug: SlavaKvak@a359db3

@okcompute
Copy link
Contributor Author

okcompute commented May 17, 2016

Hi all,

Thank you very much for taking the time to fix this issue. It is really appreciated. I confirm the bug is fixed in the month view. But, for me, it still present in the week view:

week
week2

I'm using version 0.9.11

@okcompute
Copy link
Contributor Author

And now with the fix:

week_fix
week2_fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants